-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(TableHeader): update sortable table header aria description for voice over #7383
Conversation
@@ -18,24 +18,27 @@ import { sortStates } from './state/sorting'; | |||
const { prefix } = settings; | |||
|
|||
const translationKeys = { | |||
iconDescription: 'carbon.table.header.icon.description', | |||
buttonDescription: 'carbon.table.header.icon.description', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️ Deploy preview for carbon-elements ready! 🔨 Explore the source changes: d29063d 🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/5fc9292fb911c70008d31f54 😎 Browse the preview: https://deploy-preview-7383--carbon-elements.netlify.app |
✔️ Deploy preview for carbon-components-react ready! 🔨 Explore the source changes: d29063d 🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-components-react/deploys/5fc9292f5ce18200080c5e51 😎 Browse the preview: https://deploy-preview-7383--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful! Speaks really well in my tests with JAWS 2020 and NVDA 👏 👏
Also got an all-clear from Accessibility Checker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, nice work! 🎉 ✅ 👍
Closes #7369
Changelog
When tabbing/entering a header this is announced: (description of how to sort, which way it will sort/by which header (name) you are sorting).