fix(tooltip): correct scroll width caused by #7309 #7414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 6257c41 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 6257c41 https://deploy-preview-7414--carbon-components-react.netlify.app |
|
✔️ Deploy preview for carbon-elements ready! 🔨 Explore the source changes: 8c10b93 🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/5fd259b16bd82000080986d4 😎 Browse the preview: https://deploy-preview-7414--carbon-elements.netlify.app |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 8c10b93 https://deploy-preview-7414--carbon-components-react.netlify.app |
lee-chase
changed the title
tw15egan
requested review from
a team and
jeanservaas
and removed request for
a team
jeanservaas
approved these changes
Dec 10, 2020
tw15egan
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
status: visual review 🔍
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The alignment of the tooltip created in #7309 moved the inner (content) part of the tip. This meant that the outer part caused the width of the component to include space outside the display area of the tip, even when the tip was shown with the direction of the setting: bottom align: end. This could cause a scroll bar in circumstances where the tip appeared to be displayed entirely within the available space.
In addition #7309 appeared to square off the top corners of the tip.
This PR reverts the SCSS changes in #7309 and instead styles the outer tooltip element and carrot to the correct positions.
Changelog
Changed
packages/components/src/components/tooltip/_tooltip.scss
Testing / Reviewing
Visually inspected the 8 off center cases.