Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dropdown): state disabled background color #7461

Merged
merged 3 commits into from
Dec 16, 2020
Merged

fix(dropdown): state disabled background color #7461

merged 3 commits into from
Dec 16, 2020

Conversation

epodgaetskiy
Copy link
Contributor

This PR makes compliance with the guide

Changelog

Changed

  • Indicated a specific color for the disabled state. The error was not visible because the colors in the theme correspond to field-01 and disabled-01.

Testing / Reviewing

  • Pull PR
  • Look fix at netlify storybook for dropdown :disabled

@epodgaetskiy epodgaetskiy requested a review from a team as a code owner December 15, 2020 17:06
@netlify
Copy link

netlify bot commented Dec 15, 2020

✔️ Deploy preview for carbon-elements ready!

🔨 Explore the source changes: 8fc9d60

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/5fd8ed0b618ec9000803ee28

😎 Browse the preview: https://deploy-preview-7461--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Dec 15, 2020

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit 8fc9d60

https://deploy-preview-7461--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Dec 15, 2020 •
edited
Loading

✔️ Deploy preview for carbon-elements ready!

🔨 Explore the source changes: 54a0270

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/5fd9cb989b53180007e6bbde

😎 Browse the preview: https://deploy-preview-7461--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Dec 15, 2020 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit 54a0270

https://deploy-preview-7461--carbon-components-react.netlify.app

@kodiakhq kodiakhq bot merged commit 81aa04f into carbon-design-system:master Dec 16, 2020
@epodgaetskiy epodgaetskiy mentioned this pull request Dec 16, 2020
Closed
tw15egan added a commit that referenced this pull request Dec 16, 2020
@tw15egan
Revert "fix(dropdown): state disabled background color (#7461)"
3b8cea9 
This reverts commit 81aa04f.
@tw15egan tw15egan mentioned this pull request Dec 16, 2020
Merged
kodiakhq bot added a commit that referenced this pull request Jan 5, 2021
@tw15egan @joshblack @kodiakhq
Revert "fix(dropdown): state disabled background color (#7461)" (#7473)
978fbdd 
This reverts commit 81aa04f.

Co-authored-by: Josh Black <josh@josh.black>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw15egan tw15egan tw15egan approved these changes

@dakahn dakahn dakahn approved these changes

@emyarod emyarod Awaiting requested review from emyarod

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@epodgaetskiy @tw15egan @dakahn