Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-shell): remove menubar role #7462

Merged
merged 3 commits into from
Jan 5, 2021

Conversation

tw15egan
Copy link
Member

Closes #7377

Removes role based on @dakahn 's comments

Ah! I figured it out. We've got role="menubar" on the <ul> itself in horizontal mode (not mobile, in a dialog). In AIW's eyes this negates any semantics we get from that <ul> -- thus the warning.

Changelog

Removed

  • removes role="menubar" from HeaderNavigation

Testing / Reviewing

Ensure there are no a11y violations

@netlify
Copy link

netlify bot commented Dec 15, 2020

✔️ Deploy preview for carbon-elements ready!

🔨 Explore the source changes: 9dd4845

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/5ff4ebec48ba6f0008528bf0

😎 Browse the preview: https://deploy-preview-7462--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Dec 15, 2020

✔️ Deploy preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 9dd4845

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-components-react/deploys/5ff4ebecd7dbf40007394b13

😎 Browse the preview: https://deploy-preview-7462--carbon-components-react.netlify.app

@kodiakhq kodiakhq bot merged commit 77fd9a7 into carbon-design-system:master Jan 5, 2021
@tw15egan tw15egan deleted the header-a11y branch April 28, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI Shell - AIW violation for non-semantic list items
3 participants