Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(tooltip): add additional note for missing tooltip props #7472

Merged
merged 2 commits into from
Dec 17, 2020

Conversation

tw15egan
Copy link
Member

Closes #7470

Adds in a note for the two missing props autogenerated by Storybook

Changelog

New

  • Note explaining when to use iconDescription property

Testing / Reviewing

Ensure the note makes sense

@tw15egan tw15egan requested a review from a team as a code owner December 16, 2020 19:08
@netlify
Copy link

netlify bot commented Dec 16, 2020

✔️ Deploy preview for carbon-elements ready!

🔨 Explore the source changes: 0387cb3

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/5fdb7ffd61ea870007666d3a

😎 Browse the preview: https://deploy-preview-7472--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Dec 16, 2020

❌ Deploy preview for carbon-components-react failed.
Built without sensitive environment variables

🔨 Explore the source changes: 0387cb3

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-components-react/deploys/5fdb7ffd847f290008fd8c35

Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@kodiakhq kodiakhq bot merged commit 00ad3fe into carbon-design-system:master Dec 17, 2020
@tw15egan tw15egan deleted the tooltip-docs branch April 28, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storybook/Docs not mentioning iconDescription prop for Tooltip react component
3 participants