-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style(DataTable): fix sortable table header padding #7726
Conversation
Deploy preview for carbon-elements ready! Built with commit 0ec1f66 |
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 0ec1f66 https://deploy-preview-7726--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was fast!
If using a table that has a mix of sortable headers and not sortable headers this causes the non-sortable headers to have no padding. I assume you would need to do something like as well to compensate for that use case?
|
Closes #7724
Scopes the padding to the proper element when using the
sortable
version ofDataTable
Changelog
Changed
th
and applied it to the button that receives hover stylesTesting / Reviewing
Ensure hover styles are correct on the Sortable version of DataTable, and that no other variants have changed