Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multi-select): remove left padding on filterable input after selection #7740

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Feb 4, 2021

Closes #7735

Related #7722

This PR removes the left padding on the filterable multiselect input field after making a selection, resolving an existing issue with filterable multiselect spacing

Testing / Reviewing

Confirm the filterable multiselect input has the correct spacing from the tag

@netlify
Copy link

netlify bot commented Feb 4, 2021

Deploy preview for carbon-elements ready!

Built with commit 55fc5c6

https://deploy-preview-7740--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Feb 4, 2021

Deploy preview for carbon-components-react ready!

Built with commit 55fc5c6

https://deploy-preview-7740--carbon-components-react.netlify.app

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the tag appears in the input after selecting an option, the text in the input is still too far away from the tag. It needs to be 8px/1rem.
Artboard

@emyarod emyarod force-pushed the 7735-filterable-multiselect-padding branch from 54f3531 to 222a160 Compare February 4, 2021 17:55
@emyarod emyarod changed the title fix(multi-select): remove right margin on filterable tag fix(multi-select): remove left padding on filterable input after selection Feb 4, 2021
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻

@emyarod emyarod force-pushed the 7735-filterable-multiselect-padding branch from 222a160 to 55fc5c6 Compare February 5, 2021 17:48
@kodiakhq kodiakhq bot merged commit dce7e7d into carbon-design-system:master Feb 5, 2021
@emyarod emyarod deleted the 7735-filterable-multiselect-padding branch February 8, 2021 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[multi-select] incorrect filterable multi-select padding
4 participants