Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toggle): adjust disabled toggle styles in data table #7753

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Feb 5, 2021

Closes #7351

This PR adds one off disabled styles for toggles in data tables. The example story will be removed prior to merging

Testing / Reviewing

Check the Test data table story and confirm the disabled toggle appears correct

@netlify
Copy link

netlify bot commented Feb 5, 2021

Deploy preview for carbon-elements ready!

Built with commit 9ab19e7

https://deploy-preview-7753--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Feb 5, 2021

Deploy preview for carbon-components-react ready!

Built with commit 9ab19e7

https://deploy-preview-7753--carbon-components-react.netlify.app

@aagonzales
Copy link
Member

Looks good! Thanks for making the test story.

Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@emyarod emyarod force-pushed the 7351-disabled-toggle-in-data-table branch 2 times, most recently from 92feb19 to 9c9c164 Compare February 11, 2021 16:39
@emyarod emyarod force-pushed the 7351-disabled-toggle-in-data-table branch from 9c9c164 to 9ab19e7 Compare February 11, 2021 16:39
@kodiakhq kodiakhq bot merged commit 42374bc into carbon-design-system:master Feb 11, 2021
@emyarod emyarod deleted the 7351-disabled-toggle-in-data-table branch February 11, 2021 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabled Toggles inside Data Tables are wrong color
4 participants