-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(components): include side effects from src for rollup resolution #7774
fix(components): include side effects from src for rollup resolution #7774
Conversation
Deploy preview for carbon-elements ready! Built with commit 037516d |
Deploy preview for carbon-components-react ready! Built with commit 037516d https://deploy-preview-7774--carbon-components-react.netlify.app |
Deploy preview for carbon-elements ready! Built with commit e65448f |
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit e65448f https://deploy-preview-7774--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #7773
Adds in the relevant src files to the
sideEffects
array to correctly emit our document event listeners on boot.Changelog
New
Changed
sideEffects
incomponents/package.json
to include source files so that rollup's node-resolve plugin correctly emits imports that have side effectsRemoved
Testing / Reviewing
yarn gulp scripts:rollup
is a nice shortcut inpackages/components
)scripts/components.js
and verify that the following block of code appears at the end: