Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(motion): add duration tokens to motion #7782

Merged

Conversation

joshblack
Copy link
Contributor

Closes #7738

Adds support for duration tokens to the motion package.

Changelog

New

  • Add tests for public API of motion package

Changed

  • Update module style and JS entrypoints to include duration tokens

Removed

Testing / Reviewing

  • Verify token values are correct
  • Verify tokens appear correctly in snapshots for the motion package

@joshblack joshblack requested a review from a team as a code owner February 11, 2021 18:27
@netlify
Copy link

netlify bot commented Feb 11, 2021

Deploy preview for carbon-elements ready!

Built with commit b42aac7

https://deploy-preview-7782--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Feb 11, 2021

Deploy preview for carbon-components-react ready!

Built with commit b42aac7

https://deploy-preview-7782--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Feb 11, 2021

Deploy preview for carbon-elements ready!

Built with commit 425e76c

https://deploy-preview-7782--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Feb 11, 2021

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit 425e76c

https://deploy-preview-7782--carbon-components-react.netlify.app

Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@tw15egan
Copy link
Member

@joshblack looks like snapshots just need to be updated

Copy link
Contributor

@dakahn dakahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@carbon/motion should include motion duration tokens
3 participants