fix(PasswordInput): add missing button class #7799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit dc357c6 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit dc357c6 https://deploy-preview-7799--carbon-components-react.netlify.app |
jnm2377
approved these changes
Feb 12, 2021
This was referenced Feb 16, 2021
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7765
This PR adds a missing class to the controlled password input component so that it appears correct. We should look into props and state syncing for a future version of the password inputs
Testing/Reviewing
Confirm the controlled password input story appears correct