feat(project): add styles experiment #7854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @carbon-design-system/developers-system if you're interested 👀 |
|
Deploy preview for carbon-elements ready! Built with commit f400795 |
|
Deploy preview for carbon-components-react ready! Built with commit f400795 https://deploy-preview-7854--carbon-components-react.netlify.app |
|
Deploy preview for carbon-elements ready! Built with commit 9315229 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 9315229 https://deploy-preview-7854--carbon-components-react.netlify.app |
…feat/add-styles-stub
…to feat/add-styles-stub
tw15egan
approved these changes
Feb 22, 2021
emyarod
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in a private package at
packages/stylescalled@carbon/styles. This package is not meant to be published unless we confirm as a team that we want to move our styles to a scoped package.As an experiment, this package is paired alongside our migration to Sass Modules to help influence/guide how that transition will happen. It is designed in a way that we could rename the package, merge it into
carbon-components, etc. at the end of the experiment.This initial PR sets up the first thoughts around what our first-class Sass API should look like, including bringing in previous Sass Modules migrations for our elements packages, along with introducing a migration document for
carbon-componentsto assist with documenting public files and their exports.Changelog
New
packages/stylespackage with initial files and testscarbon-componentsto document public API in terms of files and module members to make sure we take care of them in the migrationChanged
Removed