fix(TextInput): match skeleton state to other form elements #7865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw15egan
requested review from
a team and
johnbister
and removed request for
a team
|
Deploy preview for carbon-elements ready! Built with commit 94d6ac3 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 94d6ac3 https://deploy-preview-7865--carbon-components-react.netlify.app |
laurenmrice
requested review from
laurenmrice
and removed request for
johnbister
andreancardona
approved these changes
Feb 25, 2021
tw15egan
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs slack convo: https://ibm-studios.slack.com/archives/C2K6RFJ1G/p1613486609314400
the
inputof theTextInputcomponent was not getting Skeleton styles, which was causing visual issues when used in conjunction with other form elements. This matches theTextInputskeleton styles toSelect,NumberInput, etc..Changelog
New
Skeletonstyles when theskeletonclass is added toTextInputTesting / Reviewing
Ensure
TextInputSkeletonlooks like other form elements when using the skeleton variant