fix(AccordionItem): animate open/close when open prop is specified
#7876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit f72318c |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit f72318c https://deploy-preview-7876--carbon-components-react.netlify.app |
joshblack
approved these changes
Feb 23, 2021
jnm2377
approved these changes
Feb 24, 2021
tw15egan
requested review from
a team and
laurenmrice
and removed request for
tay1orjones and
a team
tw15egan
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: visual review 🔍
labels
This was referenced Nov 5, 2021
|
This change may have caused this issue: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7875
This PR adds the AccordionItem's animation hooks to the open prop/state sync so that animations appear when the
openprop value is changedTesting / Reviewing
Toggle the
openprop in the playground story and observe that the accordion item opens and closes with animations