fix(checkbox): avoid outline cutoff in hidden overflow containers #7887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 97cff71 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 97cff71 https://deploy-preview-7887--carbon-components-react.netlify.app |
jnm2377
approved these changes
Feb 25, 2021
jnm2377
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
emyarod
deleted the
6480-checkbox-focus-outline-in-hidden-overflow-container
branch
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6480
This PR increases checkbox spacing so that the box shadow which appears on focus does not get cut off in containers with hidden overflow
Changelog
Changed
Testing / Reviewing
add
overflow: hiddento a checkbox container and confirm that the checkbox focus outline is not cut off