fix(RadioButton): remove empty span if label text is falsey #7904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 032bca2 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 032bca2 https://deploy-preview-7904--carbon-components-react.netlify.app |
andreancardona
added
status: one more review 👀
and removed
status: ready for review 👀
labels
tw15egan
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes an empty span element when the radio button labelText is falsey. There was a case where a falsey labelText value together with
hideLabel="true"would render an empty span with.bx--visually-hiddenstylesTesting/Reviewing
Clear the label in the radio button storybook and confirm that the empty span is no longer rendered