feat(CodeSnippet): add copy functionality with external package #8105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw15egan
force-pushed
the
add-copy-alternate
branch
from
592c8f3
to
48bb710
Compare
|
Deploy preview for carbon-elements ready! Built with commit 1b6c4ce |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 1b6c4ce https://deploy-preview-8105--carbon-components-react.netlify.app |
jnm2377
approved these changes
Mar 17, 2021
guigueb
suggested changes
Mar 18, 2021
tw15egan
force-pushed
the
add-copy-alternate
branch
from
150bbed
to
b134154
Compare
tay1orjones
approved these changes
Mar 22, 2021
tay1orjones
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternate to #8103
Closes #6995
Closes #4448
This PR adds in the same functionality as #8103, but uses the external
copy-to-clipboardpackage to handle copying for better browser support. This will still prevent copying if a user has already provided anonClickChangelog
New
copy-to-clipboardadded as a dependencyonClickis not provided toCodeSnippetTesting / Reviewing
Test
inlineandsinglecomponents, the code should be copied. Testmultiandplayground, the code should not be copied