fix(ComposedModal): add scrolling content class automatically #8153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshblack
approved these changes
Mar 22, 2021
|
Deploy preview for carbon-elements ready! Built with commit dc3796d |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit dc3796d https://deploy-preview-8153--carbon-components-react.netlify.app |
dakahn
approved these changes
Mar 22, 2021
tw15egan
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: visual review 🔍
labels
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8136
This PR adds a missing condition for a modal body scroll overflow class on the ComposedModal so that it matches Modal
Testing / Reviewing
Ensure the modal overflow indicator is not visible when scrolling to the bottom of the modal body