fix(ListBox): correctly position menu chevron #8155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 28a0833 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 28a0833 https://deploy-preview-8155--carbon-components-react.netlify.app |
tay1orjones
approved these changes
Mar 22, 2021
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8147
This PR fixes the listbox menu chevron icon again so that it is always vertically centered. reverts #7990 (reopening #7989 in the process, which stems from #7777)
Testing / Reviewing
Confirm that the chevron icon is correctly positioned in all sizes and variants of dropdown, multiselect, and combobox