Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(date-picker): remove border radius #8198

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Mar 26, 2021

Closes #8190

This PR removes the border radius of the flatpickr calendar to match the component spec

@netlify
Copy link

netlify bot commented Mar 26, 2021

Deploy preview for carbon-elements ready!

Built with commit c310d7a

https://deploy-preview-8198--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Mar 26, 2021

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit c310d7a

https://deploy-preview-8198--carbon-components-react.netlify.app

@github-actions
Copy link
Contributor

DCO Assistant Lite bot: Thanks for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text:


I have read the DCO document and I hereby sign the DCO.


You can retrigger this bot by commenting recheck in this Pull Request

@kodiakhq kodiakhq bot merged commit 4f2ff8b into carbon-design-system:main Mar 31, 2021
@shixiedesign
Copy link
Contributor

Hmm... I think I still see it in the preview build?
image

@tw15egan
Copy link
Member

Hmm yeah, it seems like it's not picking up the border-radius from flatpickr-calendar and needs to be added to .flatpickr-calendar.open for some reason.

cc @emyarod

@emyarod
Copy link
Member Author

emyarod commented Mar 31, 2021

will take another look

@emyarod
Copy link
Member Author

emyarod commented Mar 31, 2021

I don't think it's related to the open class, it's just the rule a few lines down

@emyarod emyarod deleted the 8190-override-flatpickr-calendar-styles branch March 31, 2021 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Date picker] Remove rounded corner
4 participants