fix(combobox): match "clear selection" icon fill when disabled #8208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 2c20166 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 2c20166 https://deploy-preview-8208--carbon-components-react.netlify.app |
joshblack
approved these changes
Mar 29, 2021
tw15egan
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the "X" button to clear a combobox's selection is still shown in
icon-01when the control is disabled. This PR updates the icon fill to usedisabled-02.Before
After
Changelog
Changed
disabled-02as icon fill for "clear selection" button in combobox when control is disabledTesting / Reviewing
icon-01when the control is not disabled