fix(ie11): add ie11 to autoprefixer, add grid: autoplace #8215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshblack
approved these changes
Mar 29, 2021
|
Deploy preview for carbon-elements ready! Built with commit c57d708 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit c57d708 https://deploy-preview-8215--carbon-components-react.netlify.app |
tay1orjones
approved these changes
Mar 31, 2021
tay1orjones
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
|
Thanks for the fix. FWIW, I did try to test this on IE11, from the link you gave, but Storybook itself won't run on IE; I think it needs some polyfills / transpilation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6919
Refs #8176
Adds
ie >= 11to our browser matrix, also enables thegrid: autoplacefeature of autoprefixer. There are some known caveats. If someone could test these in IE11 that would be great (I do not have access at the moment)Changelog
New
grid: autoplacefeature of autoprefixerChanged
ie >= 11to our browser matrixTesting / Reviewing
Any changes should just be scoped to IE11. A quick search of the compiled css shows 18 instances of the new
-ms-gridvendor prefix. The following components should be tested in IE11:FileUploader(.bx--file__selected-file)Listbox/Dropdown(.bx--list-box__wrapper--inlineand.bx--list-box__wrapper--inline .bx--form-requirement)Modal(.bx--modal-container,.bx--modal-header)