fix(Tooltip): v11 (next) accessibility refactor #8324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy Preview for carbon-elements ready! Built with commit 7482562 |
|
Deploy Preview for carbon-components-react ready! Built with commit 7482562 https://deploy-preview-8324--carbon-components-react.netlify.app |
…05-tooltip-a11y-overhaul
…05-tooltip-a11y-overhaul
…05-tooltip-a11y-overhaul
…05-tooltip-a11y-overhaul
dakahn
added
status: ready for review 👀
component: tooltip
and removed
status: WIP 👩💻
labels
dakahn
changed the title
joshblack
approved these changes
May 20, 2021
jnm2377
reviewed
May 21, 2021
| }; | ||
|
|
||
| export const Default = () => { | ||
| const sizes = [ |
There was a problem hiding this comment.
should we name this alignment or direction or something similar?
jnm2377
approved these changes
May 21, 2021
jnm2377
added
status: ready to merge 🎉
and removed
component: tooltip
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #8575
ref #8305
Accessibility refactor for Tooltip ⚡
changes