fix(breakpoint): update in between breakpoint #8346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshblack
approved these changes
Apr 9, 2021
|
Deploy preview for carbon-elements ready! Built with commit ddf33ea |
|
Deploy preview for carbon-components-react ready! Built with commit ddf33ea https://deploy-preview-8346--carbon-components-react.netlify.app |
jeffchew
added a commit
to jeffchew/carbon
that referenced
this pull request
Jul 2, 2021
This is reverting from the PR merge carbon-design-system#8346, which breaks the mixin from allowing entering any breakpoint names (sm, md, etc).
kodiakhq bot
added a commit
that referenced
this pull request
Jul 6, 2021
…et (#9102) * fix(breakpoint): revert breakpoint-between removal of breakpoints map This is reverting from the PR merge #8346, which breaks the mixin from allowing entering any breakpoint names (sm, md, etc). * fix(breakpoint): fixing calculation to have +/- 0.02 outside of map-get Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8186
Update
carbon--breakpoint-betweenbreakpoint by adding the following:For reference: The
carbon--breakpoint-downwas also updated and that PR can bee seen here: https://github.com/carbon-design-system/carbon/pull/5791/files