fix(PasswordInput): resolve visibility toggle style issues #8673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emyarod
requested review from
johnbister,
tw15egan and
jnm2377
and removed request for
a team
|
Deploy preview for carbon-elements ready! Built with commit f055883 |
|
Deploy preview for carbon-components-react ready! Built with commit f055883 https://deploy-preview-8673--carbon-components-react.netlify.app |
|
@emyarod the focus border looks like the right size/position! Just wondering if the icon focus border should be disabled when text input is disabled? If this isn't a problem or if it's something that would better be addressed in a separate PR, let me know and I'll go ahead and approve these changes. Thanks! Screen.Recording.2021-05-13.at.8.21.13.AM.mov |
|
@johnbister that issue is resolved in #8368 |
emyarod
force-pushed
the
8672-password-input-visual-bugs
branch
from
f6f77f1
to
f055883
Compare
jnm2377
approved these changes
May 13, 2021
jnm2377
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: visual review 🔍
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8672
This PR restores the focus outline to the password input visibility toggle button and properly positions it for all component size variants
Testing / Reviewing
Verify that the focus border appears as expected on the password input visibility toggle and that it is properly sized and aligned in all size variants of the component