fix(button): explicitly set width for expressive theme #8686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy Preview for carbon-elements ready! Built with commit e38a0cb |
emyarod
force-pushed
the
8685-specify-btn-set-max-width-rules
branch
from
57c0162
to
59447a4
Compare
|
Deploy preview for carbon-components-react failed. Built with commit 57c0162 https://app.netlify.com/sites/carbon-components-react/deploys/609d8462a746260007045cd9 |
|
Deploy Preview for carbon-components-react ready! Built without sensitive environment variables with commit e38a0cb https://deploy-preview-8686--carbon-components-react.netlify.app |
joshblack
approved these changes
May 17, 2021
tw15egan
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
status: visual review 🔍
labels
2 tasks
87 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8685
related #8477
This PR resolves a regression where expressive theme button styles would impact modal footer button sets. The selector has been modified so that it explicitly targets expressive theme button sets now
Testing / Reviewing
Confirm default, expressive, and modal footer button sets appear as expected