fix(DatePicker): avoid unknown attribute on div #8747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 417df8e 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60ad2d2532c9e50008f42fa4 😎 Browse the preview: https://deploy-preview-8747--carbon-elements.netlify.app |
|
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 417df8e 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60ad2d2532c9e50008f42f9c 😎 Browse the preview: https://deploy-preview-8747--carbon-components-react.netlify.app |
emyarod
force-pushed
the
8743-remove-allowInput-from-datepicker-container
branch
from
71a3e07
to
5e04fd2
Compare
dakahn
approved these changes
May 24, 2021
sstrubberg
approved these changes
May 25, 2021
emyarod
force-pushed
the
8743-remove-allowInput-from-datepicker-container
branch
from
6d34057
to
417df8e
Compare
87 tasks
emyarod
added a commit
to emyarod/carbon
that referenced
this pull request
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8743
related #7037
This PR avoids adding the
allowInputprop as an unknown attribute on the date picker containerTesting / Reviewing
Confirm that no prop warnings are emitted after setting a value for
allowInputon<DatePicker />