fix(packages-type): fix custom properties breakpoint #8763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 58c12f9 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60ae6835826584000777aeb8 😎 Browse the preview: https://deploy-preview-8763--carbon-elements.netlify.app |
|
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 58c12f9 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60ae68355bca7400079e0365 😎 Browse the preview: https://deploy-preview-8763--carbon-components-react.netlify.app |
joshblack
approved these changes
May 26, 2021
andreancardona
added
status: ready to merge 🎉
and removed
status: ready for review 👀
labels
87 tasks
emyarod
pushed a commit
to emyarod/carbon
that referenced
this pull request
Jun 10, 2021
…ystem#8763) Co-authored-by: Scott Strubberg <sstrubberg@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8668
We are removing the expected
breakpointsproperty when custom properties are enabled since the default state for$fluidis false. The bug was breaking type styles when custom properties are enabled.Testing
cd
packages/reactand in your terminal / command line setexport CARBON_REACT_STORYBOOK_USE_SASS_LOADER=true*** don't forget to change this back after testing by running:
export CARBON_REACT_STORYBOOK_USE_SASS_LOADER=falsein the
packages --> react --> .storbyook --> .styles.scsson line 12 add the following:$feature-flags: ( enable-css-custom-properties: true, );To test for example accordion add the following css selector
.bx--accordion__title {
@include carbon--type-style('expressive-heading-05');
}
run storybook
you should see just like something below where the accordion title is receiving the correct type style while custom properties are enabled
in your terminal run:
export CARBON_REACT_STORYBOOK_USE_SASS_LOADER=false