Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(colors): add hover colors to @carbon/colors #8942

Merged
merged 28 commits into from
Jun 24, 2021

Conversation

joshblack
Copy link
Contributor

Closes #8822

This PR updates our @carbon/colors package to include the hover palette from the IDL. It also updates our build task to export hover variables in Sass.

Changelog

New

  • Hover colors from the IDL

Changed

  • Update build taskt to emit hover colors

Removed

Testing / Reviewing

  • Pull down the PR locally
  • Make sure to run yarn build in @carbon/colors
  • Verify that the scss/mixins.scss file includes the hover colors from the IDL
  • Verify that the index.scss file includes the hover colors from the IDL

@joshblack
Copy link
Contributor Author

FYI @sstrubberg here's that draft PR!

@netlify
Copy link

netlify bot commented Jun 17, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: e1a51c5

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60d50a4eb84985000813696f

😎 Browse the preview: https://deploy-preview-8942--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jun 17, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: e1a51c5

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60d50a4ef2583a000757f528

😎 Browse the preview: https://deploy-preview-8942--carbon-components-react.netlify.app

@sstrubberg
Copy link
Member

FYI @sstrubberg here's that draft PR!

Thx! I got all the colors in. Still getting some build errors though and i'm not confident about the tests either.

@netlify
Copy link

netlify bot commented Jun 22, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: e1a51c5

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60d50a4e97b0a600075d8340

😎 Browse the preview: https://deploy-preview-8942--carbon-react-next.netlify.app/iframe

@joshblack joshblack marked this pull request as ready for review June 23, 2021 17:57
@joshblack joshblack requested a review from a team as a code owner June 23, 2021 17:57
@joshblack
Copy link
Contributor Author

joshblack commented Jun 23, 2021

FYI @aagonzales in this PR we are adding the hover colors from the IDL into the colors package. We used the values from the file and converted them to HEX. The value themselves are defined in the colors.js file in the PR 👀

Copy link
Member

@sstrubberg sstrubberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so many colors!

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@joshblack
Copy link
Contributor Author

Also just a heads up @aagonzales I updated the colors preview so the table should include the color hovers in there with the hex value 👍

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Values that need to be updated:
Purple-10-hover: #ede5ff
Cyan-100-hover: #0b2947
Blue-30-hover: #8ab6ff

@joshblack
Copy link
Contributor Author

joshblack commented Jun 24, 2021

Thanks @aagonzales ! Just updated. Just a quick heads up, all the *.snap files are generated so feel free to look at the colors.js file here: https://github.com/carbon-design-system/carbon/pull/8942/files#diff-e2ecd2a0df3376b7c433e2fdc41d587c14a3b56ce0b6bfa65bb6385246fe69e7 and disregard the rest (should save some time, I hope 🤞 )

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol i was dumb and didn't even think to look at the elements preview smh

@kodiakhq kodiakhq bot merged commit df64f1c into carbon-design-system:main Jun 24, 2021
@joshblack joshblack deleted the 8822-add-hover-colors-v2 branch June 25, 2021 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add hover color values to the @carbon/colors package
4 participants