Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(number-input): match readonly variant #8992

Merged
merged 3 commits into from
Jul 1, 2021

Conversation

janhassel
Copy link
Member

Related #8806

This PR aligns the readonly number input variant with the behaviour and visual apperance of the text input.

image

Changelog

Changed

  • Update behaviour and visual appearance of readOnly variant of the NumberInput

Testing / Reviewing

Ensure no regression unrelated to the following changes occured:

  • Has EditOff16 icon
  • Transparent input background
  • Normal cursor (can select text)
  • readonly takes precedence over invalid
  • readonly takes precedence over warn
  • readonly takes precedence over disabled
  • No steppers shown

@janhassel janhassel requested a review from a team as a code owner June 22, 2021 16:24
@netlify
Copy link

netlify bot commented Jun 22, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: bf07c7e

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60de2b6e4922eb0008e3fc8a

😎 Browse the preview: https://deploy-preview-8992--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jun 22, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: bf07c7e

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60de2b6ec5e8dd000846ad4e

😎 Browse the preview: https://deploy-preview-8992--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Jun 25, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: bf07c7e

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60de2b6e2e1fb10007b4e091

😎 Browse the preview: https://deploy-preview-8992--carbon-react-next.netlify.app

@kodiakhq kodiakhq bot merged commit d0bd8ed into carbon-design-system:main Jul 1, 2021
@janhassel janhassel deleted the number-input-readonly branch July 2, 2021 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants