Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(StructuredList): fix feature-flag function usage #9033

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

tw15egan
Copy link
Member

Refs #8931

After working on #9004 with @andreancardona , we realized that the feature-flag function will fail silently if not imported, resulting in weird styling issues like below

Screen Shot 2021-06-24 at 5 17 24 PM

Changelog

Changed

  • feature-flag-enabled renamed to enabled
  • Fixed a spelling error, and updated the feature flag name to the correct one (code)

Testing / Reviewing

StructuredList with Selection should no longer have visible Radio Buttons

cc @sstrubberg

@netlify
Copy link

netlify bot commented Jun 24, 2021

❌ Deploy Preview for carbon-react-next failed.

🔨 Explore the source changes: d43688f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60e49abd0fbeb7000711e238

@netlify
Copy link

netlify bot commented Jun 24, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: d43688f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60e49abd2cb4bc00089a3eb2

😎 Browse the preview: https://deploy-preview-9033--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jun 24, 2021

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: d43688f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60e49abdcd84c000076a640c

😎 Browse the preview: https://deploy-preview-9033--carbon-components-react.netlify.app

@kodiakhq
Copy link
Contributor

kodiakhq bot commented Jul 6, 2021

This PR currently has a merge conflict. Please resolve this and then re-add the status: ready to merge 🎉 label.

@kodiakhq kodiakhq bot merged commit dabaf4f into carbon-design-system:main Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants