fix(react): update radio button group state initialization #9104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9041
This updates how we initialize our
selected
state value from a||
expression to a ternary that checks if the value is undefined. When using||
, the state would be incorrectly initialized if the value was false-y but not undefined (like the value0
).I also took this small change to convert some of the tests for
RadioButtonGroup
to RTL. It also updates thejest-dom
matchers to be brought in automatically.Changelog
New
Changed
RadioButtonGroup.js
to correctly initializeselected
stateRadioButtonGroup-test.js
file to start using RTLjest-config-carbon
to automatically bring injest-dom
matchersRemoved
Testing / Reviewing
RadioButtonGroup
mishandles the input falsy value as an undefined value #9041