Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Storybook): move margin to wrapper #9154

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

tw15egan
Copy link
Member

@tw15egan tw15egan commented Jul 9, 2021

#9150

Moves marginBottom to the wrapping div so invalid styles are not affected when present

Testing / Reviewing

Ensure invalid styles work correctly in the FormGroup story

@tw15egan tw15egan requested a review from a team as a code owner July 9, 2021 13:37
@netlify
Copy link

netlify bot commented Jul 9, 2021

❌ Deploy Preview for carbon-react-next failed.

🔨 Explore the source changes: aac6bcf

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60e860b4145fd02418f11e0a

@netlify
Copy link

netlify bot commented Jul 9, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: aac6bcf

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60e851282da72200089566a6

😎 Browse the preview: https://deploy-preview-9154--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 9, 2021

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: aac6bcf

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60e851287fbabe000819c785

😎 Browse the preview: https://deploy-preview-9154--carbon-components-react.netlify.app

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@kodiakhq kodiakhq bot merged commit fb96217 into carbon-design-system:main Jul 9, 2021
@tw15egan tw15egan deleted the form-group-margin branch March 3, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants