feat: add carbon telemetry #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ibm-cloud-cognitive ready! Built with commit 9f0893f |
davidmenendez
approved these changes
Mar 18, 2021
dcwarwick
suggested changes
Mar 18, 2021
There was a problem hiding this comment.
Review of dependencies
@carbon/telemetry is being added as a new dependency:
- Verify the dependency has previously been pedigree reviewed
- Verify the dependency doesn't contain any vulnerabilities
- Verify the dependency bundle size is acceptable
- Verify the dependency is actively maintained
- Verify license conditions are met e.g. forwarding of copyright if necessary.
dcwarwick
approved these changes
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #305
Add Carbon telemetry to cloud-cognitive and cloud-cognitive-experimental packages.
What did you change?
package.json in cloud-cognitive and cloud-cognitive-experimental packages.
How did you test and verify your work?
Ran ci-check