This repository has been archived by the owner on Jan 12, 2019. It is now read-only.
Fix camera preview not showing on first launch #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lkorth Hi Luke, can you have a look at this PR and if it's ok, merge it into the project ? |
|
Any update in this? Is this project still being maintained? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The preview appears once the surface is created and there is a callback for the creation. Except that the callback is registered in prepareScanner which is called after the SurfaceView is actually created. I can confirm because I registered callbacks in the Preview class and they where called before entering prepareScanner.
So what I am doing is checking in the resumeScanning if the SurfaceView is valid.
card-io/card.io-Android-SDK#189