Skip to content
This repository has been archived by the owner on Jan 12, 2019. It is now read-only.

feature: scan_progress #73

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

m-schmoock
Copy link
Contributor

@m-schmoock m-schmoock commented May 11, 2016

It's helpful to track the scan progress state (focus, edge, vseg, hseg, stability...).
It enables additional functionality like visible user feedback guidance
or autofocus trigger once hseg is reached which I have also put
in the pull requests (dmz and android).

This increases user experience because:

  • The user does not have to trigger autofocus manually by tapping on the display that may shake the device and decrease detection rate / user experience.
  • The user gets visible feedback on 'how good' the card can be currently scanned by a progress bar and guide colors. This helps subconsciously so the user holds the card in a way a successful scan is more likely/sooner to happen.

@m-schmoock
Copy link
Contributor Author

m-schmoock commented May 11, 2016

Note: The build only fails because the required DMZ changes cannot be fetched since they are not merged yet: card-io/card.io-dmz#30

int width = (int) (GUIDE_STROKE_WIDTH / 2 * mScale);
int height = (int) (50 * mScale);
int offset = (int) (10 * mScale);
for ( int i = 0; i < scanProgress; i++) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spacing is not consistent. Don't put a space before int.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed by e0b1376

@m-schmoock
Copy link
Contributor Author

m-schmoock commented May 26, 2016

Maybe we leave the color of the guide frame as defined (GREEN) and do the fancy color effect just on the progress bar...

Note: The build still fails because the required DMZ changes cannot be fetched yet since they are unmerged: card-io/card.io-dmz#30

* progress color only applied to progress indicator bar
* progress indicator bar elements are now incremential
@m-schmoock
Copy link
Contributor Author

Like this. Updated the progress color behavior. Guide frame color is now unchanged.

Note: The build still fails because the required DMZ changes cannot be fetched yet since they are unmerged: card-io/card.io-dmz#30

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants