Skip to content
This repository has been archived by the owner on Jan 12, 2019. It is now read-only.

Added support for Carthage #122

Closed
wants to merge 7 commits into from
Closed

Added support for Carthage #122

wants to merge 7 commits into from

Conversation

ky1ejs
Copy link

@ky1ejs ky1ejs commented Jul 9, 2015

No description provided.

@josharian
Copy link
Member

This is the first I've heard of Carthage. I like the idea of a decentralized dependency manager and having card.io support for it seems like a worthwhile goal. However, I'm having a hard time understanding these commits, their purpose, and how they relate to Carthage. Also, I wonder whether this support should be done in the source repo rather than the SDK repo. (Maybe not, given that we have custom build steps, but it's worth double-checking.)

@ky1ejs
Copy link
Author

ky1ejs commented Jul 10, 2015

The commits just:

  1. Make an Xcode project, which provides build settings and scheme for Cathage to use to build a framework wrapping the headers and the static library
  2. Update docs for instructions on using Card.io with Carthage

I'll look in to adding to the source repo – didn't know that existed.

@josharian
Copy link
Member

@kylejm apologies for the long silence. Where does this stand now?

@ky1ejs
Copy link
Author

ky1ejs commented Jul 24, 2015

I haven't added it to the source repo... yet. I may look into it. Feel free to decline this PR if you think it doesn't really make sense for this static library repo :)

@josharian josharian mentioned this pull request Jul 24, 2015
@josharian
Copy link
Member

@kylejm I really would like to see a decentralized dependency manager take off, but yes, I don't think that this is the right place for card.io Carthage support. I'm going to close this, but I've opened #130 so that we do have an open issue for it.

@josharian josharian closed this Jul 24, 2015
@ky1ejs
Copy link
Author

ky1ejs commented Jul 24, 2015

Awesome stuff. Have you made the issue on the SDK repo though and not the source repo?

@josharian
Copy link
Member

Oops. Yes. Will fix, thanks.

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants