-
Notifications
You must be signed in to change notification settings - Fork 554
Add .m so that CocoaPods will generate CardIO modulemap #210
Conversation
@@ -0,0 +1 @@ | |||
// This file exists so that CocoaPods will generate a modulemap for CardIO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add links to the issues it fixes.
LGTM with that tweak, but leaving to others to approve and merge. |
Updated! |
Another option here if we don't want to opt all users into this behavior is that we can add a subspec that includes this file, but leave the default as it is today. |
Let me know if you would prefer that and I can make that change. |
Are there any downsides to opting everyone in? |
Nevermind, this will only affect users who have |
A cleaner option would be to provide a module map and not rely on cocoapods' automatic one (which didn't properly enable auto-linking with the various system frameworks your framework requires, last time I checked). See the |
Just tried that configuration. It seems like CocoaPods doesn't pick up the modulemap file in this case. It might be because of having multiple |
LGTM, thanks for your contribution! |
Thank you! |
This PR ended up getting reverted because linking failed in some cases. Here's a new version that seems to work correctly with Objective-C and Swift https://github.com/card-io/card.io-iOS-SDK/pull/284/files |
This fixes the issues discussed in #115 and #126 since changing the project structure was nixed as a solution. This allows users to import CardIO from Swift without using a bridging header.