Skip to content
This repository has been archived by the owner on Jan 12, 2019. It is now read-only.

Exposed scanned image duration to iOS SDK #28

Closed
wants to merge 0 commits into from

Conversation

ClaudeSutterlin
Copy link

There was no way to reduce scanned image duration to 0 seconds, so there was always a flash of the card numbers on the screen. We had a client request that the numbers are never shown in that manner, so I exposed that value to the SDK.

There was some inconsistency in code formatting, so apologies for those modifications. I ended up using the following settings for my changes:
Tab width: 2 spaces
Indent width: 2 spaces
✓ Automatically trim trailing whitespace
✓ Including whitespace-only lines

@@ -1767,7 +1767,7 @@
LastUpgradeCheck = 0630;
TargetAttributes = {
3E9F4C4A181F07B700F33B48 = {
DevelopmentTeam = V8KL7848Q4;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't really matter, but since this isn't a substantive change, probably worth removing from this PR.

@josharian
Copy link
Member

Thanks. This seems reasonable, and the implementation is definitely straightforward. I've not thought much about iOS in a while, though; @dgoldman-ebay what do you think?

I appreciate the whitespace cleanup. However, I'd like to keep it separate from the functional changes. I pulled it in as 6732275; thanks! This means you'll need to rebase these changes, for which I apologize...but the resulting commit should be much cleaner. If you would, please take this opportunity to also squash your three commits into one. Please also revert the changes to .gitmodules and icc.xcodeproj/project.pbxproj. (If you don't know how to do these things, just let me know and I can help.)

@dgoldman-pdx
Copy link
Member

I'll wait until @ClaudeSutterlin has a chance to follow @josharian's requests, and then do a nice and picky review. 😺

@ClaudeSutterlin
Copy link
Author

@josharian @dgoldman-ebay Thanks folks, I was being a little bit careless. I'll sort those issues out.

Regarding my change to .gitmodules though, I was getting a permission denied issue when trying to pull down the submodules per your instructions. After I updated the path to how you see it here, I was able to sync them. I'll revert the changes, but thought I'd give a heads up.

@josharian
Copy link
Member

@ClaudeSutterlin regarding .gitmodules, it's tricky -- some folks don't have github/ssh playing together nicely, but others don't have a credential cache set up, so https is frustrating for them. I'd prefer to leave it as ssh instead of https, although I'm open to compelling arguments to the contrary. In the meantime, the best suggestion I have (which is not great) is to use insteadOf: https://coderwall.com/p/sitezg/force-git-to-clone-with-https-instead-of-git-urls.

@braebot
Copy link
Member

braebot commented Jul 6, 2015

Feel free to submit arguments for/against https & ssh in an SO question I asked long ago. :)

Jeff

cysp added a commit to cysp/card.io-iOS-source that referenced this pull request Sep 14, 2016
+4a94a1cb Forward-declare struct ScannerState for compatibility with the iOS project
+4ae1cbf0 Merge pull request card-io#33 from COCUS-NEXT/feature/blur
+9a25c052 chore: variable rename: unblur to unblurDigits
+45e315dd Update license year and company
+d9381ce5 Merge pull request card-io#31 from card-io/dgoldman/master/docs
+25369d3f README.md: add pointers to some documentation
+3291a212 Merge pull request card-io#28 from COCUS-NEXT/feature/blur
+51538328 feat: implement blur in DMZ sources
+32d1bc13 Merge pull request card-io#27 from willsteel/master
+e4d68dcf fix: Android-source issue card-io#60
+2efa16c5 add x86-64
+269fc2f0 Merge pull request card-io#20 from card-io/android-64-bit
+b1c5f508 add 64-bit arm android processor detection
cysp added a commit to cysp/card.io-iOS-source that referenced this pull request Sep 24, 2016
+324250d4 Forward-declare struct ScannerState for compatibility with the iOS project
+05dd0aee Merge pull request card-io#35 from cysp/feature/mastercard-2series
+02e1c436 Add MasterCard 2-Series
+4ae1cbf0 Merge pull request card-io#33 from COCUS-NEXT/feature/blur
+9a25c052 chore: variable rename: unblur to unblurDigits
+45e315dd Update license year and company
+d9381ce5 Merge pull request card-io#31 from card-io/dgoldman/master/docs
+25369d3f README.md: add pointers to some documentation
+3291a212 Merge pull request card-io#28 from COCUS-NEXT/feature/blur
+51538328 feat: implement blur in DMZ sources
+32d1bc13 Merge pull request card-io#27 from willsteel/master
+e4d68dcf fix: Android-source issue card-io#60
+2efa16c5 add x86-64
+269fc2f0 Merge pull request card-io#20 from card-io/android-64-bit
+b1c5f508 add 64-bit arm android processor detection
cysp added a commit to cysp/card.io-iOS-source that referenced this pull request Oct 16, 2017
+0aac4a05 Merge pull request card-io#41 from card-io/20170224_standardize_issue_template
+0aef13ce Standardize ISSUE_TEMPLATE.md
+d3e09c66 Standardize ISSUE_TEMPLATE.md
+4a6f5efc Standardize ISSUE_TEMPLATE.md
+8c62386a Merge pull request card-io#37 from cysp/feature/ios-compilefix
+324250d4 Forward-declare struct ScannerState for compatibility with the iOS project
+05dd0aee Merge pull request card-io#35 from cysp/feature/mastercard-2series
+02e1c436 Add MasterCard 2-Series
+4ae1cbf0 Merge pull request card-io#33 from COCUS-NEXT/feature/blur
+9a25c052 chore: variable rename: unblur to unblurDigits
+45e315dd Update license year and company
+d9381ce5 Merge pull request card-io#31 from card-io/dgoldman/master/docs
+25369d3f README.md: add pointers to some documentation
+3291a212 Merge pull request card-io#28 from COCUS-NEXT/feature/blur
+51538328 feat: implement blur in DMZ sources
+32d1bc13 Merge pull request card-io#27 from willsteel/master
+e4d68dcf fix: Android-source issue card-io#60
+2efa16c5 add x86-64
+269fc2f0 Merge pull request card-io#20 from card-io/android-64-bit
+b1c5f508 add 64-bit arm android processor detection
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants