Exposing scannedImageDuration to SDK #29
Conversation
|
LGTM; thanks! @dgoldman-ebay, I'm leaving this to you to merge (or not) as you see fit. |
| @@ -26,6 +26,7 @@ | |||
| @property(nonatomic, assign, readwrite) BOOL disableBlurWhenBackgrounding; | |||
| @property(nonatomic, assign, readwrite) BOOL suppressScanConfirmation; | |||
| @property(nonatomic, assign, readwrite) BOOL suppressScannedCardImage; | |||
| @property(nonatomic, assign, readwrite) CGFloat scannedImageDuration; | |||
There was a problem hiding this comment.
Can you move this new line down below to just before the allowFreelyRotatingCardGuide line? That will keep it consistent with the properties order in CardIOConfig.h. (Not that we've always been consistent in the past!)
|
Okay, 3 teensy picky requests about line order, and one small but substantive request (change a comment and add a line inside Let us know when you've got those in, and I'll merge this in. And then, probably this weekend, make a new official release. |
| @@ -76,6 +76,13 @@ | |||
| /// Defaults to NO. | |||
| @property(nonatomic, assign, readwrite) BOOL suppressScannedCardImage; | |||
|
|
|||
| /// After a successful scan, the CardIOView will briefly display an image of the card with | |||
There was a problem hiding this comment.
Oh, 1 more teensy picky request. We shouldn't mention the CardIOView here. If you can think of a better wording, go for it. Or else you can leave that to me, post-merge.
|
@dgoldman-ebay Thanks for the review. I've made all of the suggested changes. One thing I'm slightly uncomfortable with is the default value. Would you be okay with setting the value on the CardIOContext directly (in
I don't see any precedent for that, so I'd rather ask what you prefer. |
|
@ClaudeSutterlin yes, that's exactly what I had in mind. |
ClaudeSutterlin
force-pushed
the
master
branch
2 times, most recently
from
99776d1
to
8919438
Compare
Exposing scannedImageDuration to SDK
|
Incorporated in Version 5.1.0. |
There was no way to reduce scanned image duration to 0 seconds, so there was always a flash of the card numbers on the screen. We had a client request that the numbers are never shown in that manner, so I exposed that value to the SDK.