This repository has been archived by the owner on Jan 12, 2019. It is now read-only.
Skip invalid IplImage from being scanned #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -133,8 +133,8 @@ - (void)detectCardInSamplesWithFlip:(BOOL)shouldFlip { | |||
| dmz_transform_card(self.dmz, self.ySample.image, self.corner_points, frameOrientation, false, &foundCardY); | |||
| self.cardY = [CardIOIplImage imageWithIplImage:foundCardY]; | |||
There was a problem hiding this comment.
Should this assignment to self.cardY also wait until we've confirmed that foundCardY is valid?
I.e., if we get as far as the call to dmz_transform_card(), but the result is invalid, then act as if foundCard were false.
There was a problem hiding this comment.
Yup, sounds good. I amended the commit.
- In very odd but numerous reports, there are instances where the IplImage does not have a valid header. This could cause a crash notably in: [CardIOView didScanCard:] [CardIOVideoFrame imageWithGrayscale:] [CardIOIplImage rgbImageWithY:cb:cr:] void dmz_YCbCr_to_RGB(IplImage *y, IplImage *cb, IplImage *cr, IplImage **rgb) and eventually calls cvGetSize() which throws an exception with "Array should be CvMat or IplImage". This code tries to detect invalid IplImage values earlier and skips using them for scans.
bluk
force-pushed
the
skip_invalid_iplimage
branch
from
5de2b02
to
d2d16c3
Compare
|
Looks reasonable to me! |
bluk
added a commit
that referenced
this pull request
Jan 26, 2016
Skip invalid IplImage from being scanned
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In very odd but numerous crash reports, there are instances where the IplImage does
not have a valid header. This could cause a crash notably calling through (reversed stack trace):
and eventually calls
cvGetSize()which throws an exception with"Array should be CvMat or IplImage".
This code tries to detect invalid IplImage values earlier and skips scanning them.