Skip to content
This repository has been archived by the owner on Jan 12, 2019. It is now read-only.

Updated CardIOVideoStream's delegate to be a UIResponder to fix Xcode 8 compiler error #70

Merged
merged 1 commit into from
Aug 16, 2016
Merged

Conversation

reidmain
Copy link
Contributor

Detailed explanation of this change is in issue #69

@reidmain
Copy link
Contributor Author

I can't figure out how to run unit tests for the project. If I select the UnitTest scheme and try to build it I immediately get the build error CodeSign error: code signing is required for product type 'OCUnit Test Bundle' in SDK 'iOS 9.3'.

Is there something specific that needs to be configured for the unit tests?

@reidmain reidmain changed the title Updated CardIOVideoStream's delegate to be a UIResponder to fix a Xcode 8 compiler error Updated CardIOVideoStream's delegate to be a UIResponder to fix Xcode 8 compiler error Aug 12, 2016
@josharian
Copy link
Member

LGTM. Leaving to someone else to merge. Don't sweat the tests. For this trivial a change in a heavily used code path, if it compiles and basic functionality works, I'd say it's good.

@reidmain
Copy link
Contributor Author

Cool. I ran the example app on device and was able to recognize a credit card with no issues.

@reidmain
Copy link
Contributor Author

Is there someone we can ping who can merge this PR?

@josharian
Copy link
Member

@bluk @braebot

@bluk bluk merged commit ba8e643 into card-io:master Aug 16, 2016
@bluk
Copy link
Contributor

bluk commented Aug 16, 2016

@reidmain Looks good to me. Thanks for the PR and sorry for the delay.

@reidmain
Copy link
Contributor Author

@bluk no worries. Xcode 8 isn't even GM yet so I understand. If I experience any more issues while trying to integrate this into a Swift 2.3 app I'll open up some more.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants