Skip to content
This repository has been archived by the owner on Jan 12, 2019. It is now read-only.

Use HTTPS URL for submodule to allow read access for non GH users #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Johennes
Copy link

@Johennes Johennes commented Apr 5, 2017

This is required to be able to clone the repository and its submodules without having a GitHub account. An example use case is consuming card.io through carthage to build an iOS application within a large team of engineers where people simply cannot be required to sign up for GitHub and upload their SSH key just to build the app.

See also Carthage/Carthage#1865

This is required to be able to clone the repository and its submodules
without having a GitHub account. An example use case is consuming card.io
through carthage to build an iOS application within a large team of
engineers where people simply cannot be required to sign up for GitHub
and upload their SSH key just to build the app.

See also Carthage/Carthage#1865
@josharian
Copy link
Member

Thanks for the pull request. This has been discussed fairly extensively in the past, but my search fu is failing me. There are benefits to both ssh and https. If you need https, you can use git's insteadof support: https://stackoverflow.com/questions/1722807/git-convert-git-urls-to-http-urls.

@Johennes
Copy link
Author

Johennes commented Apr 5, 2017

Thanks for the pointer. So putting this into my global .gitconfig

[url "https://github.com/card-io/card.io-dmz.git"]
    insteadOf = git@github.com:card-io/card.io-dmz.git

indeed makes card.io work with carthage. I still think it would be nice if no additional setup was required just for consuming the framework but I'm fine with this if SSH brings benefits in other use cases. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants