Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PublishDate to Potato Feed #305

Closed
wants to merge 3 commits into from
Closed

Add PublishDate to Potato Feed #305

wants to merge 3 commits into from

Conversation

onedr0p
Copy link

@onedr0p onedr0p commented Jan 14, 2017

Thanks for submitting a pull request! If you aren't submitting a new indexer definition, you can delete all this text and write a summary of your change.

For a new indexer, please follow this checklist:

  • Run cardigann test definitions/trackername.yml and include the output here:
Definition file for alpharatio parsed OK ✓
Testing indexer alpharatio
Indexer alpharatio passed ✓
  • Make sure to add the indexer to the list in the README

If you run into issues with testing, remember you can run a debug test with cardigann test --debug --cachepages definitions/trackername.yml.

@onedr0p
Copy link
Author

onedr0p commented Jan 17, 2017

In case you're wondering it was added to the CouchPotato wiki

https://github.com/CouchPotato/CouchPotatoServer/wiki/Couchpotato-torrent-provider

@kaso17
Copy link
Collaborator

kaso17 commented Jan 19, 2017

Can you update the code to make it UTC ISO 8601 format?

@kaso17
Copy link
Collaborator

kaso17 commented Jan 19, 2017

And does this work if an indexer doesn't set the date field?

@onedr0p
Copy link
Author

onedr0p commented Jan 19, 2017

@kaso17 I do not know GoLang that well, perhaps you can add the date to reflect that format? I made this PR with the hopes you would help out a bit, since they are small changes.

Also, if the indexer doesn't support date, I don't expect it to break anything, it would just not be present in the API call (like how IMDBID doesn't exist for some).

Thanks for your help.

@kaso17
Copy link
Collaborator

kaso17 commented Jan 20, 2017

We're probably at a similar skill level regarding GoLang ;)
You probably have to change the datatype to string and call Time.UTC().Format("...") during the assignment.
item.PublishDate.UTC().Format(time.RFC3339) might work.
If that format constant doesn't result in the expected layout you probably have to build your own format string.
In that case I recommend http://fuckinggodateformat.com/

@onedr0p
Copy link
Author

onedr0p commented Jan 26, 2017

@kaso17 feel free to modify my PR this is over my head.

@onedr0p
Copy link
Author

onedr0p commented Jan 26, 2017

@lxt2 @kaso17 Also see here #327 this is essential for Radarr working with cardigann, please if you can prioritize them. Thanks 👍 We will stop getting issue reports on Radarr :)

@kaso17
Copy link
Collaborator

kaso17 commented Jan 26, 2017

@lxt2 disappeared and I've no plans to become the new main developer of cardigann leaving this project more or less dead for now.
@kblanks agreed on helping with it as good as he can, maybe he can help with this one too.

@onedr0p
Copy link
Author

onedr0p commented Jan 26, 2017

Maybe one of you guys should fork this repo, and leave a message in the readme here about this being dead? Or should we just advise people to use jackett instead?

@kaso17
Copy link
Collaborator

kaso17 commented Jan 26, 2017

@kblanks is already preparing the fork.

The main reasons why cardigann was born were frequent Jackett crashes in certain environments (Many of them have been fixed recently). A secondary reason was the mono requirement leading to an overall higher resource footprint. The mono argument isn't very strong in combination with Radarr.

Jackett supports all trackers (and many more) supported by cardigann at the same or better level. So unless you're planning to run it on a super memory constraint embedded system Jackett is the better option at this time, especially with the unknown future of cardigann.

@Dnkhatri
Copy link

Dnkhatri commented Jan 26, 2017 via email

@onedr0p onedr0p closed this Feb 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants