Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize getAnimations() calls #28

Open
nickschot opened this issue Mar 30, 2022 · 2 comments
Open

Optimize getAnimations() calls #28

nickschot opened this issue Mar 30, 2022 · 2 comments

Comments

@nickschot
Copy link
Contributor

Two points we need to consider:

  1. Using document.getAnimations() to pause all animations in willTransition may be more efficient than doing it per sprite as we'd issue a single call to the DOM
  2. getAnimations() returns all animations, including CSS transitions/animations. Not sure yet if we can distinguish between them and if it matters.
@nickschot
Copy link
Contributor Author

nickschot commented Apr 15, 2022

(1) has been implemented in #31 in a very basic way

@nickschot nickschot changed the title getAnimations() Optimize getAnimations() calls Aug 19, 2022
@nickschot
Copy link
Contributor Author

This may not be needed if we time our DOM reads/writes properly.

ef4 pushed a commit that referenced this issue Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant