Allow dashboard menu links with query parameters #3313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
danieloh0714
approved these changes
Jun 18, 2024
brunofrts
added a commit
that referenced
this pull request
Jun 20, 2024
* refs/heads/master: Move `develocity` block after `plugins` (#3321) chore: upgrade dependencies to close security vulnerabilities (#3323) Deprecate Config tab in admin dashboard menu (#3322) Add description to Metadata class, Add AlertMessage, CodeBlock, ToggleContainer components (#3316) Fix Metadata tab overflow scrolling (#3315) Add contract to requireRequest (#3318) Delete misk-events-testing which has been replaced by misk-events test fixtures (#3317) Add id to Metadata tab h1 (#3314) Allow dashboard menu links with query parameters (#3313) Refactor JvmMetadataAction into Metadata plugin (#3305) Fix ConfigMetadata prettyPrint to match Config tab (#3311) Make metadata classes internal (#3310) Add metadata for cron jobs (#3309) Add metadata example to exemplar, make backwards compat (#3306) Make AllMetadataAction filterable (#3303) # Conflicts: # misk-admin/src/test/kotlin/misk/web/metadata/all/AllMetadataActionTest.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This anticipates the use case where for backwards compatability purposes we want to keep a menu link but point it to a local URL with a query parameter. For example, keeping a Config link but pointing it to
/_admin/metadata/?q=config.