R2DBC: Await closing the driver #4139
Conversation
hfhbd
force-pushed
the
hfhbd/r2dbc-awaitClosing
branch
from
0d51e47
to
ee503b6
Compare
hfhbd
force-pushed
the
hfhbd/r2dbc-awaitClosing
branch
from
ee503b6
to
3c548f6
Compare
| /** | ||
| * This callback is called after [close]. It either contains an error or null, representing a successful close. | ||
| */ | ||
| val closed: (Throwable?) -> Unit, |
There was a problem hiding this comment.
| val closed: (Throwable?) -> Unit, | |
| val closed: (Throwable?) -> Unit = {}, |
I feel like in most cases we don't actually need any special handing for this.
There was a problem hiding this comment.
Hm, yes and no. If you don't provide this value, you don't have an option to wait for the close call, because driver.close() will return immediately.
There was a problem hiding this comment.
Wouldn't it return immediately anyway? I would expect that this could still work as a fire-and-forget kind of thing, but that passing in a listener will let you await the completion if you really need it.
There was a problem hiding this comment.
Of course, this call isn't suspending or blocking, see the tests for a waiting implementation.
So yes, you still need to implement the listener (or we could provide an CoroutineScope overload).
There was a problem hiding this comment.
Sounds good to me either way
* R2DBC: Await closing the driver * Fix compiler error due to rebasing * Add coroutines overload * Add doc * Refactor test code with use * Spotless... --------- Co-authored-by: hfhbd <[email protected]>
The current
closeapi of the R2DBC driver does not await the result or failure of the close request. Because we can't use a suspend call, I added a normal plain old callback.