Fix 4474 PostgreSql create extension #4541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
griffio
changed the title
|
is this schema altering - as in we also need though maybe supporting autocomplete and stuff for these isn't that important, as you mentioned I think folks would have to implement a custom dialect which is probably the right path for this |
|
Yes - just supporting I created a new discussion to try point out what I mean at the higher level 🧑🚀 |
Support CREATE EXTENSION … Overrides the extension_stmt to add unsupported CREATE EXTENSION
…_stmt Extensions with fixture tests for supported syntax CreateExtensionTests removed as not needed in this change
|
Updating this old 🗝️ PR as may be of use with a custom dialect https://github.com/griffio/sqldelight-custom-dialect |
AlecKazakova
approved these changes
Feb 2, 2024
hfhbd
pushed a commit
that referenced
this pull request
Apr 2, 2024
* PostgreSql create extension fixup Support CREATE EXTENSION … Overrides the extension_stmt to add unsupported CREATE EXTENSION * Grammar for create_extension_stmt drop_extension_stmt alter_extension_stmt Extensions with fixture tests for supported syntax CreateExtensionTests removed as not needed in this change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support CREATE EXTENSION … ALTER EXTENSION ... DROP EXTENSION
Overrides the
extension_stmtto add EXTENSION statementsfixes #4474
However, it doesn't solve the problem where sql extensions allow new functions and types as these are unknown to PostgreSqlTypeResolver (It's possible to extend a new local dialect see https://github.com/griffio/sqldelight-custom-dialect).
Currently, another work around is to use () around the function e.g
(uuid_generate_v4())- the parser allows this for now as it's not strict enough.