Bind arguments with SqlBinaryExpr #4604
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4504
馃ぞ This PR is just to try out and see if any quick fixes
Try and lookup the parent
SqlColumnExpr
to get the type of the columnOnly the parent column can tell us what the type actually is declared as e.g Instant
Currently the tests pass and local snapshot works with cases
馃摀 The user will be required to implement and provide a ColumnAdapter for Instant to LocalDateTime, so the generated code would look like this e.g
CAST doesn't work with SqlBinaryExpr
In this contrived example, CAST doesn't force
factor
to be an INTEGER - the inferred type is REAL as the literal expression is chosen for the bind parameter type. Of course, the column result type is REALShould generate
bindLong
notbindDouble
Also cases of multiple CAST with bindArgs of different types