Fix 4448 missing import for table model #4885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the result to use tableName
a fixture where the migration sqm files and query sq files are in varying packages. This tests that the Queries interface imports the Data tables using the migration package name when ReturningQueryable is used
AlecKazakova
approved these changes
Dec 5, 2023
hfhbd
pushed a commit
that referenced
this pull request
Apr 2, 2024
* Update ReturningQueryable.kt Change the result to use tableName * add MigrationQueryTest for ReturningQueryable a fixture where the migration sqm files and query sq files are in varying packages. This tests that the Queries interface imports the Data tables using the migration package name when ReturningQueryable is used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4448
馃 This is for both Sqlite and Postgresql dialects that support
RETURNING *app.cash.sqldelight.dialect.api.ReturningQueryablenow returns the parent table reference instead of the statement table reference to use the correct package name that is taken from the source fileSelectQueryableworks alreadye.g the
CREATE TABLE Test ...is contained incom\example\migration\1.sqmINSERT INTO Test()...RETURNING*is contained incom\example\queries\Data.sqThe generated
DataQueriesmust containimport com.example.migration.TestThe other migration fixtures assume that
sqmandsqare co-located in same directory and thus work.